lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 265/336] staging: lustre: llite: correct removexattr detection
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: James Simmons <jsimmons@infradead.org>

    [ Upstream commit 1b60f6dfa38403ff7c4d0b4b7ecdb810f9789a2a ]

    In ll_xattr_set_common() detect the removexattr() case correctly by
    testing for a NULL value as well as XATTR_REPLACE.

    Signed-off-by: John L. Hammond <john.hammond@intel.com>
    Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10787
    Reviewed-on: https://review.whamcloud.com/
    Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
    Reviewed-by: James Simmons <uja.ornl@yahoo.com>
    Signed-off-by: James Simmons <jsimmons@infradead.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/lustre/lustre/llite/xattr.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/staging/lustre/lustre/llite/xattr.c
    +++ b/drivers/staging/lustre/lustre/llite/xattr.c
    @@ -94,7 +94,11 @@ ll_xattr_set_common(const struct xattr_h
    __u64 valid;
    int rc;

    - if (flags == XATTR_REPLACE) {
    + /* When setxattr() is called with a size of 0 the value is
    + * unconditionally replaced by "". When removexattr() is
    + * called we get a NULL value and XATTR_REPLACE for flags.
    + */
    + if (!value && flags == XATTR_REPLACE) {
    ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_REMOVEXATTR, 1);
    valid = OBD_MD_FLXATTRRM;
    } else {

    \
     
     \ /
      Last update: 2018-08-01 20:21    [W:4.045 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site