lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 127/246] md/raid1: add error handling of read error from FailFast device
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gioh Kim <gi-oh.kim@profitbricks.com>

    [ Upstream commit b33d10624fdc15cdf1495f3f00481afccec76783 ]

    Current handle_read_error() function calls fix_read_error()
    only if md device is RW and rdev does not include FailFast flag.
    It does not handle a read error from a RW device including
    FailFast flag.

    I am not sure it is intended. But I found that write IO error
    sets rdev faulty. The md module should handle the read IO error and
    write IO error equally. So I think read IO error should set rdev faulty.

    Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
    Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com>
    Signed-off-by: Shaohua Li <shli@fb.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/md/raid1.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/md/raid1.c
    +++ b/drivers/md/raid1.c
    @@ -2462,6 +2462,8 @@ static void handle_read_error(struct r1c
    fix_read_error(conf, r1_bio->read_disk,
    r1_bio->sector, r1_bio->sectors);
    unfreeze_array(conf);
    + } else if (mddev->ro == 0 && test_bit(FailFast, &rdev->flags)) {
    + md_error(mddev, rdev);
    } else {
    r1_bio->bios[r1_bio->read_disk] = IO_BLOCKED;
    }

    \
     
     \ /
      Last update: 2018-08-01 20:18    [W:4.131 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site