lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 201/246] crypto: authenc - dont leak pointers to authenc keys
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tudor-Dan Ambarus <tudor.ambarus@microchip.com>

    [ Upstream commit ad2fdcdf75d169e7a5aec6c7cb421c0bec8ec711 ]

    In crypto_authenc_setkey we save pointers to the authenc keys in
    a local variable of type struct crypto_authenc_keys and we don't
    zeroize it after use. Fix this and don't leak pointers to the
    authenc keys.

    Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    crypto/authenc.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/crypto/authenc.c
    +++ b/crypto/authenc.c
    @@ -108,6 +108,7 @@ static int crypto_authenc_setkey(struct
    CRYPTO_TFM_RES_MASK);

    out:
    + memzero_explicit(&keys, sizeof(keys));
    return err;

    badkey:

    \
     
     \ /
      Last update: 2018-08-01 20:14    [W:4.074 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site