lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 197/336] net: phy: phylink: Release link GPIO
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Florian Fainelli <f.fainelli@gmail.com>

    [ Upstream commit daab3349ad1a69663ccad278ed71d55974d104b4 ]

    We are not releasing the link GPIO descriptor with gpiod_put() which results in
    subsequent probing to get -EBUSY when calling fwnode_get_named_gpiod(). Fix this
    by doing the release in phylink_destroy().

    Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/phy/phylink.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/phy/phylink.c
    +++ b/drivers/net/phy/phylink.c
    @@ -612,6 +612,8 @@ void phylink_destroy(struct phylink *pl)
    {
    if (pl->sfp_bus)
    sfp_unregister_upstream(pl->sfp_bus);
    + if (!IS_ERR(pl->link_gpio))
    + gpiod_put(pl->link_gpio);

    cancel_work_sync(&pl->resolve);
    kfree(pl);

    \
     
     \ /
      Last update: 2018-08-01 20:13    [W:3.974 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site