Messages in this thread | | | Date | Mon, 9 Jul 2018 13:03:31 +0100 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support |
| |
On Mon, Jul 09, 2018 at 05:31:04PM +0530, Rohit Kumar wrote: > On 7/9/2018 4:44 PM, Mark Brown wrote: > > On Fri, Jul 06, 2018 at 03:13:13PM +0530, Rohit kumar wrote:
> > > +static const struct component_master_ops sdm845_ops = { > > > + .bind = sdm845_bind, > > > + .unbind = sdm845_unbind, > > > +};
> > Why is this using the component stuff rather than the normal support for > > finding the components of audio cards?
> QCOM soundcard is dependent on platform and cpu dais which gets registered > only when ADSP is up.
This doesn't answer the question...
> This is the design being followed in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/qcom/apq8096.c?h=v4.18-rc4#n132
Oh dear, missed that :( This is also broken and should be fixed. [unhandled content-type:application/pgp-signature] | |