lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mei: bus: type promotion bug in mei_nfc_if_version()
On Mon, Jul 09, 2018 at 11:36:21AM +0000, Winkler, Tomas wrote:
> >
> > On Wed, Jul 04, 2018 at 12:34:49PM +0300, Dan Carpenter wrote:
> > > We accidentally removed the check for negative returns without
> > > considering the issue of type promotion. The "if_version_length"
> > > variable is type size_t so if __mei_cl_recv() returns a negative then
> > > "bytes_recv" is type promoted to a high positive value and treated as
> > > success.
> > >
> > > Fixes: 582ab27a063a ("mei: bus: fix received data size check in NFC
> > > fixup")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Didn't apply to my tree at all :(
>
> I will rework this, anyhow I would prefer if you can wait for my signoff before applying,
> I believe we are reasonably responsive.

Yes you are, but for trusted developers, it's fine to merge their stuff
as well. Remember, maintainers are not "gatekeepers" :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-07-09 14:05    [W:0.066 / U:1.592 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site