[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] mm: introduce put_user_page(), placeholder version
Hi John,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc4 next-20180709]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

config: x86_64-randconfig-x015-201827 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
# save the attached .config to linux build tree
make ARCH=x86_64

Note: the linux-review/john-hubbard-gmail-com/mm-fs-put_user_page-proposal/20180709-173653 HEAD 3f7da023c5e08e49489e39be9cde820b0d1ab4d6 builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> drivers/platform//goldfish/goldfish_pipe.c:334:13: error: conflicting types for 'release_user_pages'
static void release_user_pages(struct page **pages, int pages_count,
In file included from include/linux/scatterlist.h:8:0,
from include/linux/dma-mapping.h:11,
from drivers/platform//goldfish/goldfish_pipe.c:62:
include/linux/mm.h:933:20: note: previous definition of 'release_user_pages' was here
static inline void release_user_pages(struct page **pages,

vim +/release_user_pages +334 drivers/platform//goldfish/goldfish_pipe.c

726ea1a8 Jin Qian 2017-04-20 333
726ea1a8 Jin Qian 2017-04-20 @334 static void release_user_pages(struct page **pages, int pages_count,
726ea1a8 Jin Qian 2017-04-20 335 int is_write, s32 consumed_size)
c89f2750 David 'Digit' Turner 2013-01-21 336 {
726ea1a8 Jin Qian 2017-04-20 337 int i;
c89f2750 David 'Digit' Turner 2013-01-21 338
726ea1a8 Jin Qian 2017-04-20 339 for (i = 0; i < pages_count; i++) {
726ea1a8 Jin Qian 2017-04-20 340 if (!is_write && consumed_size > 0)
726ea1a8 Jin Qian 2017-04-20 341 set_page_dirty(pages[i]);
726ea1a8 Jin Qian 2017-04-20 342 put_page(pages[i]);
726ea1a8 Jin Qian 2017-04-20 343 }
726ea1a8 Jin Qian 2017-04-20 344 }
726ea1a8 Jin Qian 2017-04-20 345

:::::: The code at line 334 was first introduced by commit
:::::: 726ea1a8ea96b2bba34ee2073b58f0770800701c goldfish_pipe: An implementation of more parallel pipe

:::::: TO: Jin Qian <>
:::::: CC: Greg Kroah-Hartman <>

0-DAY kernel test infrastructure Open Source Technology Center Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2018-07-09 12:09    [W:0.066 / U:8.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site