lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH v2] selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress
On Thu, Jul 05, 2018 at 10:50:31AM -0700, John Stultz wrote:
> In the past we've warned when ADJ_OFFSET was in progress, usually
> caused by ntpd or some other time adjusting daemon running in non
> steady sate, which can cause the skew calculations to be incorrect
>
> Thus, this patch sets a flag which we check if the clock was being
> adjusted when we fail so that we don't cause false negatives.

The commit message might need an update as the code no longer sets a
flag. Other than that, it looks good to me.

Thanks,

> --- a/tools/testing/selftests/timers/raw_skew.c
> +++ b/tools/testing/selftests/timers/raw_skew.c
> @@ -134,6 +134,11 @@ int main(int argv, char **argc)
> printf(" %lld.%i(act)", ppm/1000, abs((int)(ppm%1000)));
>
> if (llabs(eppm - ppm) > 1000) {
> + if (tx1.offset || tx2.offset ||
> + tx1.freq != tx2.freq || tx1.tick != tx2.tick) {
> + printf(" [SKIP]\n");
> + return ksft_exit_skip("The clock was adjusted externally. Shutdown NTPd or other time sync daemons\n");
> + }
> printf(" [FAILED]\n");
> return ksft_exit_fail();
> }
> --
> 2.7.4
>

--
Miroslav Lichvar

\
 
 \ /
  Last update: 2018-07-09 11:27    [W:0.027 / U:2.336 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site