Messages in this thread | | | Subject | Re: [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support | From | Srinivas Kandagatla <> | Date | Mon, 9 Jul 2018 10:06:13 +0100 |
| |
Minor Nits...
On 06/07/18 10:43, Rohit kumar wrote: > +struct sdm845_snd_data { > + struct snd_soc_card *card; > + struct regulator *vdd_supply; > + uint32_t pri_mi2s_clk_count; > + uint32_t quat_tdm_clk_count; > +}; > + > + Unnecessary extra line.. > +static unsigned int tdm_slot_offset[8] = {0, 4, 8, 12, 16, 20, 24, 28}; > + > > +static struct platform_driver sdm845_snd_driver = { > + .probe = sdm845_snd_platform_probe, > + .remove = sdm845_snd_platform_remove, > + .driver = { > + .name = "msm-snd-sdm845", > + .pm = &sdm845_pm_ops, > + .owner = THIS_MODULE, setting owner is not required here!
> + .of_match_table = sdm845_snd_device_id, > + }, > +};
| |