lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched/core: remove get_cpu() from sched_fork()
On Fri, Jul 06, 2018 at 03:32:00PM +0200, Sebastian Andrzej Siewior wrote:
> On 2018-07-06 15:18:08 [+0200], Peter Zijlstra wrote:
> > On Fri, Jul 06, 2018 at 03:06:15PM +0200, Sebastian Andrzej Siewior wrote:
> > > Based on this it is possible to remove get_cpu() and use
> > > smp_processor_id() for the `cpu' variable without breaking anything.
> >
> > Almost.. I think, see init_task_preempt_count().
>
> #define init_task_preempt_count(p) do { \
> task_thread_info(p)->preempt_count = FORK_PREEMPT_COUNT; \
> } while (0)
>
> and task_thread_info() references p only. It looks good, what did I
> miss?

Argh, dammit, I read that with p == current :/

Then yes, looks ok.

\
 
 \ /
  Last update: 2018-07-09 11:02    [W:0.032 / U:10.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site