Messages in this thread |  | | Date | Mon, 9 Jul 2018 09:01:45 +0200 | | From | Greg KH <> | | Subject | Re: [PATCH] Staging:fwserial Move LINUX_VENDOR_ID to firewire.h |
| |
On Mon, Jul 09, 2018 at 11:52:30AM -0400, Janani Sankara Babu wrote: > This driver uses the same unregistered vendor id that the > firewire core does (0xd00d1e). Hence it is exposed as a > define in firewire.h. > > Signed-off-by:Janani Sankara Babu <jananis37@gmail.com> > --- > drivers/staging/fwserial/fwserial.c | 1 - > include/linux/firewire.h | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-)
staging drivers are supposed to be self-contained. Please work to get the fwserial driver out of the staging directory before adding stuff like this to a .h file that everyone includes.
thanks,
greg k-h
|  |