lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/3] vsprintf: Remove incorrect EXPORT_SYMBOL
Date
Recently boot variable 'debug_boot_weak_hash' was added (by me).  In a
classic case of cargo cult programming the novice developer added a
macro call to EXPORT_SYMBOL(). This is wrong and was pointed out on
LKML. As pointed out EXPORT_SYMBOL() cannot be used on static
variables.

Remove incorrect usage of macro EXPORT_SYMBOL()

Fixes: bfe80ed3d7c76 ("vsprintf: add command line option debug_boot_weak_hash")
Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
lib/vsprintf.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index cdc2c355dff5..fe834a201f3d 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1655,7 +1655,6 @@ static DEFINE_STATIC_KEY_TRUE(not_filled_random_ptr_key);

/* Make pointers available for printing early in the boot sequence. */
static int debug_boot_weak_hash __ro_after_init;
-EXPORT_SYMBOL(debug_boot_weak_hash);

static int __init debug_boot_weak_hash_enable(char *str)
{
--
2.17.1
\
 
 \ /
  Last update: 2018-07-10 02:28    [W:0.050 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site