lkml.org 
[lkml]   [2018]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] tools: build: Use HOSTLDFLAGS with fixdep
On Fri, Jul 06, 2018 at 06:07:04PM -0700, Laura Abbott wrote:
> The final link of fixdep uses LDFLAGS but not the existing HOSTLDFLAGS.
> Fix this.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> This was another one where I couldn't tell of the use of LDFLAGS was a
> typo or intentional, hence keeping both.

I think the replacement (using just HOSTLDFLAGS) should
be the correct fix, moreover fixdep doesn't have any special
link requirements

thanks,
jirka


> ---
> tools/build/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile b/tools/build/Makefile
> index 5eb4b5ad79cb..cd0fd2cd165b 100644
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile
> @@ -43,7 +43,7 @@ $(OUTPUT)fixdep-in.o: FORCE
> $(Q)$(MAKE) $(build)=fixdep
>
> $(OUTPUT)fixdep: $(OUTPUT)fixdep-in.o
> - $(QUIET_LINK)$(HOSTCC) $(LDFLAGS) -o $@ $<
> + $(QUIET_LINK)$(HOSTCC) $(HOSTLDFLAGS) $(LDFLAGS) -o $@ $<
>
> FORCE:
>
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2018-07-08 12:55    [W:0.047 / U:1.664 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site