lkml.org 
[lkml]   [2018]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Crypto Fixes for 4.18
On Sun, Jul 8, 2018 at 9:20 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> - Add missing RETs in x86 aegis/morus.

Side note - I queried earlier during the discussion about this: how
was this code taken despite having clearly never tested on _anything_?

That's a serious question. Code that simply has never had any testing
AT ALL should not have gotten in.

The use of 'int3' in padding showed the issue, but I don't believe the
code could possibly have worked with the nops and fallthroughs.

Linus

\
 
 \ /
  Last update: 2018-07-08 20:32    [W:0.087 / U:9.392 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site