Messages in this thread | | | Date | Mon, 9 Jul 2018 00:43:44 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v2 1/2] crypto: Fix -Wstringop-truncation warnings |
| |
On Mon, Jun 25, 2018 at 09:45:37PM +0900, Stafford Horne wrote: > As of GCC 9.0.0 the build is reporting warnings like: > > crypto/ablkcipher.c: In function ‘crypto_ablkcipher_report’: > crypto/ablkcipher.c:374:2: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation] > strncpy(rblkcipher.geniv, alg->cra_ablkcipher.geniv ?: "<default>", > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sizeof(rblkcipher.geniv)); > ~~~~~~~~~~~~~~~~~~~~~~~~~ > > This means the strnycpy might create a non null terminated string. Fix this by > explicitly performing '\0' termination. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Max Filippov <jcmvbkbc@gmail.com> > Cc: Eric Biggers <ebiggers3@gmail.com> > Cc: Nick Desaulniers <nick.desaulniers@gmail.com> > Signed-off-by: Stafford Horne <shorne@gmail.com>
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |