lkml.org 
[lkml]   [2018]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/5] ASoC: qcom: Add support to parse common audio device nodes
From
Date


On 06/07/18 10:43, Rohit kumar wrote:
> This adds support to parse cpu, platform and codec
> device nodes and add them in dai-links. Also, add
> API to add slave components associated with machine
> driver.
>
> Signed-off-by: Rohit kumar<rohitkr@codeaurora.org>
> ---
> sound/soc/qcom/Kconfig | 3 +
> sound/soc/qcom/Makefile | 1 +
> sound/soc/qcom/common.c | 150 ++++++++++++++++++++++++++++++++++++++++++++++++
> sound/soc/qcom/common.h | 14 +++++
> 4 files changed, 168 insertions(+)
> create mode 100644 sound/soc/qcom/common.c

common.c seems to miss

MODULE_LICENSE("GPL v2");

this will be an issue for snd card module auto-loading!

Also patch 5/5 can go with this.

Other than that it looks good.

Once these 2 fixed you can add my Ack

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

--srini

> create mode 100644 sound/soc/qcom/common.h

\
 
 \ /
  Last update: 2018-07-06 19:52    [W:0.293 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site