Messages in this thread | | | Date | Fri, 6 Jul 2018 06:04:07 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH v14 68/74] dax: Convert dax_lock_page to XArray |
| |
On Fri, Jun 29, 2018 at 11:30:55AM -0600, Ross Zwisler wrote: > On Sat, Jun 16, 2018 at 07:00:46PM -0700, Matthew Wilcox wrote: > > Signed-off-by: Matthew Wilcox <willy@infradead.org> > > --- > <> > > +static void *dax_make_page_entry(struct page *page, void *entry) > > +{ > > + pfn_t pfn = page_to_pfn_t(page); > > + return dax_make_entry(pfn, dax_is_pmd_entry(entry)); > > +} > > This function is defined and never used, so we get: > > fs/dax.c:106:14: warning: ‘dax_make_page_entry’ defined but not used [-Wunused-function] > static void *dax_make_page_entry(struct page *page, void *entry) > ^~~~~~~~~~~~~~~~~~~
Yeah, it was used in one of the functions Dan added, then removed. I understand he's planning on bringing that back before 4.19 and I'm going to rebase on top of that, so I've left it there for now.
| |