lkml.org 
[lkml]   [2018]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] scsi: ncr53c8xx: remove ScsiResult macro
    On Thu, Jul 05, 2018 at 05:04:05PM +0000, Bart Van Assche wrote:
    > On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote:
    > > - cmd->result = ScsiResult(DID_OK, S_CHECK_COND);
    > > + cmd->result = DID_OK << 16 | S_CHECK_COND;
    >
    > Since DID_OK == 0, do we really need "DID_OK << 16 |" here?

    Please see my answers to the other patches on this.

    Thanks,
    Johannes

    --
    Johannes Thumshirn Storage
    jthumshirn@suse.de +49 911 74053 689
    SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
    GF: Felix Imendörffer, Jane Smithard, Graham Norton
    HRB 21284 (AG Nürnberg)
    Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

    \
     
     \ /
      Last update: 2018-07-06 10:10    [W:2.575 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site