lkml.org 
[lkml]   [2018]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Use short unix-style option instead of --longname.
2018-07-05 11:05 GMT+09:00  <yamada.masahiro@socionext.com>:
> Hi.
>
>> -----Original Message-----
>> From: Rob Landley [mailto:rob@landley.net]
>> Sent: Thursday, July 05, 2018 4:06 AM
>> To: trivial@kernel.org; Yamada, Masahiro/山田 真弘
>> <yamada.masahiro@socionext.com>; Kees Cook <keescook@chromium.org>; Ulf
>> Magnusson <ulfalizer@gmail.com>
>> Subject: [PATCH] Use short unix-style option instead of --longname.
>>
>> From: Rob Landley <rob@landley.net>
>>
>> Use short unix-style option instead of --longname.
>
> This is the repeat of the subject.
> Instead, could you describe the reason of this patch here please?
>
>
>> Signed-off-by: Rob Landley <rob@landley.net>
>> ---
>>
>> Avoids warning messages with the latest release of toybox, which never
>> bothered
>> to implement the --longopts nothing was using.
>
> I am fine with this patch,
> but I want the information below the --- line
> to be recorded in git.
>
>
> I think WHY is the most important part in the commit log.
>
> If the commit log only mentions 'Use short unix-style option instead of --longname'
> it is not easy to know why this commit is necessary.
>
>


Anyway, I am fine with the code diff.


Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>



>
>
>> init/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 041f3a0..192d400 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -2,9 +2,9 @@ config DEFCONFIG_LIST
>> string
>> depends on !UML
>> option defconfig_list
>> - default "/lib/modules/$(shell,uname --release)/.config"
>> + default "/lib/modules/$(shell,uname -r)/.config"
>> default "/etc/kernel-config"
>> - default "/boot/config-$(shell,uname --release)"
>> + default "/boot/config-$(shell,uname -r)"
>> default ARCH_DEFCONFIG
>> default "arch/$(ARCH)/defconfig"



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2018-07-05 08:36    [W:0.032 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site