lkml.org 
[lkml]   [2018]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] pinctrl: baytrail: Mark expected switch fall-throughs
    In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    where we are expecting to fall through.

    Addresses-Coverity-ID: 1292308 ("Missing break in switch")
    Addresses-Coverity-ID: 1292309 ("Missing break in switch")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    ---
    drivers/pinctrl/intel/pinctrl-baytrail.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
    index 6b52ea1..3420e7e 100644
    --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
    +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
    @@ -1542,11 +1542,13 @@ static void byt_irq_unmask(struct irq_data *d)
    switch (irqd_get_trigger_type(d)) {
    case IRQ_TYPE_LEVEL_HIGH:
    value |= BYT_TRIG_LVL;
    + /* fall through */
    case IRQ_TYPE_EDGE_RISING:
    value |= BYT_TRIG_POS;
    break;
    case IRQ_TYPE_LEVEL_LOW:
    value |= BYT_TRIG_LVL;
    + /* fall through */
    case IRQ_TYPE_EDGE_FALLING:
    value |= BYT_TRIG_NEG;
    break;
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-07-05 18:15    [W:3.816 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site