Messages in this thread | | | Date | Wed, 04 Jul 2018 13:58:44 -0700 (PDT) | Subject | Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit | From | Palmer Dabbelt <> |
| |
On Fri, 29 Jun 2018 09:53:49 PDT (-0700), zongbox@gmail.com wrote: > Christoph Hellwig <hch@infradead.org> 於 2018年6月29日 週五 下午3:12寫道: >> >> On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote: >> > Use generic marco to get the index and type of symbol. >> >> Why do we even need this in a uapi header? Shouldn't ELF_RISCV_R_SYM >> and ELF_RISCV_R_TYPE move to module.c? In that case we could just >> use CONFIG_64BIT. > > Make sense. I even think the all definitions can be move to include/asm/elf.h. > How do you think about that?
Sorry I've been slow about reviewing this, but I think just in the interest of getting a sane RV32I port up and running quickly (so we can try to get glibc in shape) I'm going to take this for now.
Do you mind submitting a cleanup patch?
| |