Messages in this thread | | | Subject | Re: [PATCH v2] leds: ledtrig-morse: send out morse code | From | Jacek Anaszewski <> | Date | Wed, 4 Jul 2018 22:36:33 +0200 |
| |
Hi Pavel,
On 07/04/2018 08:53 AM, Pavel Machek wrote: > On Tue 2018-07-03 17:53:28, Andreas Klinger wrote: >> Send out a morse code by using LEDs. >> >> This is useful especially on embedded systems without displays to tell the >> user about error conditions and status information. >> >> The trigger will be called "morse" >> >> The string to be send is written into the file morse_string and sent out >> with a workqueue. Supported are letters and digits. >> >> With the file dot_unit the minimal time unit can be adjusted in >> milliseconds. >> >> Also add documentation for the morse led trigger >> >> Thanks to Greg and Geert for suggesting improvements >> >> Signed-off-by: Andreas Klinger <ak@it-klinger.de> > > As I stated before, I don't think morse encoder belongs in kernel. > > LED pattern trigger should be merged, instead.
We've already agreed in [0] upon pattern sysfs file, and related patch set [1] is just to be merged.
[0] https://lkml.org/lkml/2018/5/12/142 [1] https://patchwork.kernel.org/patch/10495595/
-- Best regards, Jacek Anaszewski
| |