Messages in this thread | | | Date | Tue, 31 Jul 2018 22:41:25 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH v2 1/6] i2c: designware: use generic table matching |
| |
On 31/07/2018 17:23:04+0300, Andy Shevchenko wrote: > On Tue, 2018-07-31 at 17:02 +0300, Andy Shevchenko wrote: > > On Tue, 2018-07-31 at 15:47 +0200, Alexandre Belloni wrote: > > > Switch to device_get_match_data in probe to match the device > > > specific > > > data > > > instead of using the acpi specific function. > > > > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Oops. See below. > > > > - id = acpi_match_device(pdev->dev.driver->acpi_match_table, > > > &pdev->dev); > > > - if (id && id->driver_data) > > > - dev->flags |= (u32)id->driver_data; >
I'll change that cast to (uintptr_t). Else gcc complains about the size mismatch on 64 bit platform. I'm letting kbuild play with my branch a bit before sending v3.
-- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |