lkml.org 
[lkml]   [2018]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users
    Date
    On Tue, 2018-07-31 at 12:51 -0700, Kees Cook wrote:
    > diff --git a/drivers/Makefile b/drivers/Makefile
    > index 24cd47014657..a6abd7a856c6 100644
    > --- a/drivers/Makefile
    > +++ b/drivers/Makefile
    > @@ -76,7 +76,7 @@ obj-$(CONFIG_DMA_SHARED_BUFFER) += dma-buf/
    > obj-$(CONFIG_NUBUS) += nubus/
    > obj-y += macintosh/
    > obj-$(CONFIG_IDE) += ide/
    > -obj-$(CONFIG_SCSI) += scsi/
    > +obj-y += scsi/
    > obj-y += nvme/
    > obj-$(CONFIG_ATA) += ata/
    > obj-$(CONFIG_TARGET_CORE) += target/

    The above change not only selects scsi_common.o but also the following object
    files: scsi.o hosts.o scsi_ioctl.o scsicam.o scsi_error.o scsi_lib.o scsi_scan.o
    scsi_sysfs.o scsi_devinfo.o scsi_trace.o scsi_logging.o. That is a change that
    has not been mentioned in the patch description. That makes me wonder whether
    this is an intended change? Wouldn't a cleaner solution have been to move
    scsi_common.c into a new directory?

    Bart.

    \
     
     \ /
      Last update: 2018-07-31 22:02    [W:2.272 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site