Messages in this thread Patch in this message | | | From | zhong jiang <> | Subject | [PATCH] lib/sg_pool: remove unnecessary null check when free the object | Date | Wed, 1 Aug 2018 00:21:47 +0800 |
| |
kmem_cache_destroy/mempool_destroy has taken null check into account. so remove the redundant check.
Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- lib/sg_pool.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/sg_pool.c b/lib/sg_pool.c index 6dd3061..d1c1e63 100644 --- a/lib/sg_pool.c +++ b/lib/sg_pool.c @@ -148,10 +148,9 @@ static __init int sg_pool_init(void) cleanup_sdb: for (i = 0; i < SG_MEMPOOL_NR; i++) { struct sg_pool *sgp = sg_pools + i; - if (sgp->pool) - mempool_destroy(sgp->pool); - if (sgp->slab) - kmem_cache_destroy(sgp->slab); + + mempool_destroy(sgp->pool); + kmem_cache_destroy(sgp->slab); } return -ENOMEM; -- 1.7.12.4
| |