Messages in this thread | | | Subject | Re: [PATCH v2 1/6] i2c: designware: use generic table matching | From | Andy Shevchenko <> | Date | Tue, 31 Jul 2018 17:53:17 +0300 |
| |
On Tue, 2018-07-31 at 16:30 +0200, Alexandre Belloni wrote: > On 31/07/2018 17:23:04+0300, Andy Shevchenko wrote: > > On Tue, 2018-07-31 at 17:02 +0300, Andy Shevchenko wrote: > > > On Tue, 2018-07-31 at 15:47 +0200, Alexandre Belloni wrote:
> > > > + dev->flags |= (u32)device_get_match_data(&pdev->dev); > > > > + > > > > And since it would be changed anyway, can you actually move this > > line > > closet to if (has_acpi_companion()) one ? > > > > I need that value to be set before calling of_configure though.
AFAICS, you added those lines later, so, it would be something like
dev->flags |= ...
if (of_node) of_configure() if (has_acpi_companion()) acpi_configure()
Would it work for you?
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |