Messages in this thread | | | Subject | Re: [PATCH] net/mlx5e: Fix uninitialized variable | From | Tariq Toukan <> | Date | Tue, 31 Jul 2018 17:50:54 +0300 |
| |
On 31/07/2018 5:21 PM, Gustavo A. R. Silva wrote: > There is a potential execution path in which variable *err* is returned > without being properly initialized previously. > > Fix this by initializing variable *err* to 0. > > Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable") > Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > index fde3502..de2827a 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -4215,7 +4215,7 @@ static int mlx5e_xdp_set(struct net_device *netdev, struct bpf_prog *prog) > struct mlx5e_priv *priv = netdev_priv(netdev); > struct bpf_prog *old_prog; > bool reset, was_opened; > - int err; > + int err = 0; > int i; > > mutex_lock(&priv->state_lock); >
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Thanks.
| |