lkml.org 
[lkml]   [2018]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/6] i2c: designware: use generic table matching
On 31/07/2018 17:23:04+0300, Andy Shevchenko wrote:
> On Tue, 2018-07-31 at 17:02 +0300, Andy Shevchenko wrote:
> > On Tue, 2018-07-31 at 15:47 +0200, Alexandre Belloni wrote:
> > > Switch to device_get_match_data in probe to match the device
> > > specific
> > > data
> > > instead of using the acpi specific function.
> > >
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Oops. See below.
>
> > > - id = acpi_match_device(pdev->dev.driver->acpi_match_table,
> > > &pdev->dev);
> > > - if (id && id->driver_data)
> > > - dev->flags |= (u32)id->driver_data;
>
> It seems you forgot to remove unused variable.
>
> > > -
> > > if (acpi_bus_get_device(handle, &adev))
> > > return -ENODEV;
> > >
> > > @@ -269,6 +265,8 @@ static int dw_i2c_plat_probe(struct
> > > platform_device *pdev)
> > > else
> > > i2c_parse_fw_timings(&pdev->dev, t, false);
> > >
> > > + dev->flags |= (u32)device_get_match_data(&pdev->dev);
> > > +
>
> And since it would be changed anyway, can you actually move this line
> closet to if (has_acpi_companion()) one ?
>

I need that value to be set before calling of_configure though.

> > > acpi_speed = i2c_acpi_find_bus_speed(&pdev->dev);
> > > /*
> > > * Some DSTDs use a non standard speed, round down to the
> > > lowest
> >
> >
>
> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy

--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2018-07-31 16:31    [W:0.865 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site