lkml.org 
[lkml]   [2018]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [RFC PATCH 1/2] ARM: dt: fpga: Added binding docs for Xilinx zynqmp FPGA manager
    Date
    Thanks for the quick response..

    Please see my comments inline....

    > -----Original Message-----
    > From: Michal Simek [mailto:michal.simek@xilinx.com]
    > Sent: Tuesday, July 31, 2018 5:48 PM
    > To: Nava kishore Manne <navam@xilinx.com>; robh+dt@kernel.org;
    > mark.rutland@arm.com; Michal Simek <michals@xilinx.com>; Soren Brinkmann
    > <sorenb@xilinx.com>; atull@opensource.altera.com;
    > moritz.fischer@ettus.com; devicetree@vger.kernel.org; linux-arm-
    > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Appana Durga
    > Kedareswara Rao <appanad@xilinx.com>; chinnikishore369@gmail.com
    > Cc: Nava kishore Manne <navam@xilinx.com>
    > Subject: Re: [RFC PATCH 1/2] ARM: dt: fpga: Added binding docs for Xilinx
    > zynqmp FPGA manager
    >
    > On 1.8.2018 12:04, Nava kishore Manne wrote:
    > > New bindings document for zynqmp fpga manager.
    > >
    > > Signed-off-by: Nava kishore Manne <navam@xilinx.com>
    > > ---
    > > .../devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt | 9 +++++++++
    > > 1 file changed, 9 insertions(+)
    > > create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,zynqmp-
    > pcap-fpga.txt
    > >
    > > diff --git a/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-
    > fpga.txt b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-
    > fpga.txt
    > > new file mode 100644
    > > index 000000000000..0eac747747f5
    > > --- /dev/null
    > > +++ b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt
    > > @@ -0,0 +1,9 @@
    > > +Xilinx Zynqmp FPGA Manager
    > This should be ZynqMP.
    >
    Will fix in the next version..

    > > +
    > > +Required properties:
    > > +- compatible: should contain "xlnx,zynqmp-pcap-fpga"
    > > +
    > > +Example:
    > > + pcap: pcap@00 {
    >
    > no reason for address if there is no any below.
    >
    Will fix in the next version....

    Regards,
    Navakishore.
    \
     
     \ /
      Last update: 2018-07-31 15:13    [W:3.111 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site