lkml.org 
[lkml]   [2018]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: checkpatch: SPDX integration breaks --root
> OK. How about:
>
> though this might not work on a path with spaces
> or some such...
>
> ---
> scripts/checkpatch.pl | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f25f708cd2a7..afb9fb27908c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -852,9 +852,10 @@ sub is_maintained_obsolete {
> sub is_SPDX_License_valid {
> my ($license) = @_;
>
> - return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py"));
> + return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
>
> - my $status = `echo "$license" | python $root/scripts/spdxcheck.py -`;
> + my $root_path = abs_path($root);
> + my $status = `cd $root_path; echo "$license" | python scripts/spdxcheck.py -`;
> return 0 if ($status ne "");
> return 1;
> }

Thanks, works at least for me. Maybe use

cd "$root_path"

to get it working with paths that include spaces.

Tested-by: Charlemagne Lasse <charlemagnelasse@gmail.com>

\
 
 \ /
  Last update: 2018-07-31 08:45    [W:0.061 / U:4.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site