Messages in this thread | | | Date | Mon, 30 Jul 2018 17:56:09 -0700 | From | Jakub Kicinski <> | Subject | Re: [RFC PATCH net-next v2 09/17] ethtool: implement GET_DRVINFO message |
| |
On Mon, 30 Jul 2018 14:53:27 +0200 (CEST), Michal Kubecek wrote: > +GET_DRVINFO > +----------- > + > +GET_DRVINFO request corresponds to ETHTOOL_GDRVINFO ioctl command and provides > +basic driver information. > + > +Request contents: > + > + ETHA_DRVINFO_DEV (nested) device identification > + > +Kernel response contents: > + > + ETHA_DRVINFO_DEV (nested) device identification > + ETHA_DRVINFO_DRIVER (string) driver name > + ETHA_DRVINFO_VERSION (string) driver version > + ETHA_DRVINFO_FWVERSION (string) firmware version
FWIW I think fwinfo belongs to devlink, and should be split. Most modern drivers provide versions of multiple FW components smooshed into a single string. Perhaps it's time to allow this facility to carry multiple key: value entries?
> + ETHA_DRVINFO_BUSINFO (string) device bus address
I wonder if some of this information is also not duplicated with sysfs. There should be a link from the netdev to a sysfs device. Same for driver name.
I'm probably missing some uses (in embedded world?) and will be corrected.. :)
> + ETHA_DRVINFO_EROM_VER (string) expansion ROM version > + ETHA_DRVINFO_N_PRIV_FLAGS (u32) number of private flags > + ETHA_DRVINFO_N_STATS (u32) number of device stats > + ETHA_DRVINFO_TESTINFO_LEN (u32) number of test results > + ETHA_DRVINFO_EEDUMP_LEN (u32) EEPROM dump size > + ETHA_DRVINFO_REGDUMP_LEN (u32) register dump size
| |