Messages in this thread Patch in this message | | | From | Nayan Deshmukh <> | Date | Mon, 30 Jul 2018 18:19:36 +0530 | Subject | Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag |
| |
<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada <<a href="mailto:yamada.masahiro@socionext.com">yamada.masahiro@socionext.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi.<br> <br> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada <<a href="mailto:yamada.masahiro@socionext.com" target="_blank">yamada.masahiro@socionext.com</a>>:<br> > I refactored the include directives under include/drm/ some time ago.<br> > This flag is unneeded.<br> ><br></blockquote><div>A minor nit-pick in the commit message, something like "With the refactored include directives under include/drm, this flag is uneeded." might be better. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > Signed-off-by: Masahiro Yamada <<a href="mailto:yamada.masahiro@socionext.com" target="_blank">yamada.masahiro@socionext.com</a>><br></blockquote><div><div>With or without that the patch is Acked-by: Nayan Deshmukh <<a href="mailto:nayan26deshmukh@gmail.com" target="_blank">nayan26deshmukh@gmail.com</a>><br><br></div><div>Regards,<br></div><div>Nayan Deshmukh <br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> Ping?<br> <br> <br> > ---<br> ><br> > drivers/gpu/drm/scheduler/Makefile | 1 -<br> > 1 file changed, 1 deletion(-)<br> ><br> > diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile<br> > index bd0377c..7665883 100644<br> > --- a/drivers/gpu/drm/scheduler/Makefile<br> > +++ b/drivers/gpu/drm/scheduler/Makefile<br> > @@ -20,7 +20,6 @@<br> > # OTHER DEALINGS IN THE SOFTWARE.<br> > #<br> > #<br> > -ccflags-y := -Iinclude/drm<br> > gpu-sched-y := gpu_scheduler.o sched_fence.o<br> ><br> > obj-$(CONFIG_DRM_SCHED) += gpu-sched.o<br> > --<br> > 2.7.4<br> ><br> <br> <br> <br> -- <br> Best Regards<br> Masahiro Yamada<br> _______________________________________________<br> dri-devel mailing list<br> <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br> </blockquote></div></div>
| |