Messages in this thread | | | Subject | Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err() | From | Michael Straube <> | Date | Mon, 30 Jul 2018 12:09:14 +0200 |
| |
On 07/30/18 11:27, Michael Straube wrote: > On 07/30/18 11:02, Greg KH wrote: >> On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: >>> The function rtw_handle_tkip_mic_err() is never used, so remove it. >>> Discovered by cppcheck. >> >> That's a bad tool then, as this is used, and the build breaks when this >> patch is applied :( >> >> I've dropped it now. >> >> thanks, >> >> greg k-h >> > > Hm, that's weired, I also checked with: > > git grep -n rtw_handle_tkip_mic_err drivers/staging/rtl8188eu/ > > There were/are no uses and the driver builds and works fine here. > I don't see what I may have missed here. :( > > Regards, > Michael
The use of rtw_handle_tkip_mic_err() was added back in commit
69a1d98c831ec64cbfd381f5dcb6697e1445d239 Revert "staging:r8188eu: Use lib80211 to support TKIP"
which was applied with 'Merge 4.18-rc7 into staging-next'.
That was not applied when I sent the patch yesterday, sorry for the trouble.
Michael
| |