lkml.org 
[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/6] userns: Use irqsave variant of refcount_dec_and_lock()
    Date
    From: Anna-Maria Gleixner <anna-maria@linutronix.de>

    The irqsave variant of refcount_dec_and_lock handles irqsave/restore when
    taking/releasing the spin lock. With this variant the call of
    local_irq_save/restore is no longer required.

    Cc: Andrew Morton <akpm@linux-foundation.org>
    Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
    [bigeasy: s@atomic_dec_and_lock@refcount_dec_and_lock@g ]
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    ---
    kernel/user.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/kernel/user.c b/kernel/user.c
    index 5f65ef195259..0df9b1640b2a 100644
    --- a/kernel/user.c
    +++ b/kernel/user.c
    @@ -169,11 +169,8 @@ void free_uid(struct user_struct *up)
    if (!up)
    return;

    - local_irq_save(flags);
    - if (refcount_dec_and_lock(&up->__count, &uidhash_lock))
    + if (refcount_dec_and_lock_irqsave(&up->__count, &uidhash_lock, &flags))
    free_user(up, flags);
    - else
    - local_irq_restore(flags);
    }

    struct user_struct *alloc_uid(kuid_t uid)
    --
    2.18.0
    \
     
     \ /
      Last update: 2018-07-03 22:06    [W:4.211 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site