Messages in this thread | | | From | Ulf Hansson <> | Date | Tue, 3 Jul 2018 07:35:54 +0200 | Subject | Re: [PATCH V2] mmc: core: cd_label must be last entry of mmc_gpio struct |
| |
On 3 July 2018 at 04:25, Fabio Estevam <festevam@gmail.com> wrote: > On Mon, Jul 2, 2018 at 11:13 PM, Anson Huang <anson.huang@nxp.com> wrote: > >> I think either way is OK, since flexible array is used in kernel code quite commonly, >> so I prefer to make code change as small as possible, the original patch can also prevent >> similar bug in future. And like below commit Fabio pointed out, it also has same kind >> of fix: a158531f3c92 ("gpio: 74x164: Fix crash during .remove()"). Thanks. > > I am also fine with this patch or the one from Linus. > > Maybe Anson's patch could be applied to 4.18-rc as a bug fix and > Linus' patch could be applied to 4.19-rc1 as a cleanup/improvement?
Good idea!
I have queued up Anson's v2 patch as a fix for 4.18.
Linus, can please re-post a re-based version of your change on top!? I guess you can add Anson's and Fabio's reviewed by tags for it as well.
Kind regards Uffe
| |