lkml.org 
[lkml]   [2018]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] tracing: kprobes: Prohibit probing on notrace function
Oops, thanks!

I've missed CONFIG_FUNCTION_TRACER=n case...

On Sat, 28 Jul 2018 16:11:34 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi Masami,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on tip/perf/core]
> [also build test ERROR on v4.18-rc6 next-20180727]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/tracing-kprobes-Prohibit-probing-on-notrace-functions/20180728-145919
> config: x86_64-randconfig-x018-201829 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> kernel//trace/trace_kprobe.c: In function 'within_notrace_func':
> >> kernel//trace/trace_kprobe.c:503:10: error: implicit declaration of function 'ftrace_location_range'; did you mean 'ftrace_location'? [-Werror=implicit-function-declaration]
> return !ftrace_location_range(addr - offset, addr - offset + size);
> ^~~~~~~~~~~~~~~~~~~~~
> ftrace_location
> cc1: some warnings being treated as errors
>
> vim +503 kernel//trace/trace_kprobe.c
>
> 489
> 490 #ifdef CONFIG_KPROBE_EVENTS_ON_NOTRACE
> 491 #define within_notrace_func(tk) (false)
> 492 #else
> 493 static bool within_notrace_func(struct trace_kprobe *tk)
> 494 {
> 495 unsigned long offset, size, addr;
> 496
> 497 addr = kallsyms_lookup_name(trace_kprobe_symbol(tk));
> 498 addr += trace_kprobe_offset(tk);
> 499
> 500 if (!kallsyms_lookup_size_offset(addr, &size, &offset))
> 501 return true; /* Out of range. */
> 502
> > 503 return !ftrace_location_range(addr - offset, addr - offset + size);
> 504 }
> 505 #endif
> 506
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2018-07-28 15:42    [W:0.060 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site