lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/2] leds: add Panasonic AN30259A support
From
Date
On 07/27/2018 10:08 PM, Jacek Anaszewski wrote:
> Hi Simon,
>
> Thank you for the updated patch. It looks good in general, with
> one reservation, please refer below.

And one more issue:

drivers/leds/leds-an30259a.c: In function 'an30259a_blink_set':
drivers/leds/leds-an30259a.c:129:23: warning: unused variable 'duty'
[-Wunused-variable]
unsigned int led_on, duty;
^
BTW, this patch set version should be v4, so please set the next
one to v5.

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2018-07-27 22:23    [W:0.037 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site