Messages in this thread | | | Subject | Re: [PATCH v3 2/2] leds: add Panasonic AN30259A support | From | Jacek Anaszewski <> | Date | Fri, 27 Jul 2018 22:22:36 +0200 |
| |
On 07/27/2018 10:08 PM, Jacek Anaszewski wrote: > Hi Simon, > > Thank you for the updated patch. It looks good in general, with > one reservation, please refer below.
And one more issue:
drivers/leds/leds-an30259a.c: In function 'an30259a_blink_set': drivers/leds/leds-an30259a.c:129:23: warning: unused variable 'duty' [-Wunused-variable] unsigned int led_on, duty; ^ BTW, this patch set version should be v4, so please set the next one to v5.
-- Best regards, Jacek Anaszewski
| |