Messages in this thread | | | Date | Fri, 27 Jul 2018 17:07:31 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 06/10] staging: gasket: sysfs: convert to standard logging |
| |
On Thu, Jul 26, 2018 at 08:07:33PM -0700, Todd Poynor wrote: > From: Todd Poynor <toddpoynor@google.com> > > Drop gasket logging calls in favor of standard logging. > > Signed-off-by: Todd Poynor <toddpoynor@google.com> > --- > drivers/staging/gasket/gasket_sysfs.c | 73 +++++++++++++-------------- > 1 file changed, 35 insertions(+), 38 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c > index 1c5f7502e0d5e..418b81797e638 100644 > --- a/drivers/staging/gasket/gasket_sysfs.c > +++ b/drivers/staging/gasket/gasket_sysfs.c > @@ -3,7 +3,9 @@ > #include "gasket_sysfs.h" > > #include "gasket_core.h" > -#include "gasket_logging.h" > + > +#include <linux/device.h> > +#include <linux/printk.h> > > /* > * Pair of kernel device and user-specified pointer. Used in lookups in sysfs > @@ -66,7 +68,7 @@ static struct gasket_sysfs_mapping *get_mapping(struct device *device) > int i; > > if (!device) { > - gasket_nodev_error("Received NULL device!"); > + pr_debug("%s: Received NULL device\n", __func__);
I know you are just trying to clean up the logging mess, but this type of check isn't even needed, as it's impossible.
thanks,
greg k-h
| |