Messages in this thread | | | Date | Fri, 27 Jul 2018 15:31:06 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init() |
| |
On Fri, Jul 27, 2018 at 04:34:25PM +0800, Jia-Ju Bai wrote: > m88e1116r_config_init() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |