lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/kprobes: Simplify the logic of enable_trace_kprobe()
On Thu, 26 Jul 2018 11:43:52 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Thu, Jul 26, 2018 at 12:11:52PM -0400, Steven Rostedt wrote:
> >
> > [ Note this is applied on top of the other patch to quiet gcc ]
> >
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > The function enable_trace_kprobe() performs slightly differently if the file
> > parameter is passed in as NULL on non-NULL. Instead of checking file twice,
> > move the code between the two tests into a static inline helper function to
> > make the code easier to follow.
> >
> > Link: http://lkml.kernel.org/r/20180725224728.7b1d5db2@vmware.local.home
> >
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> The enable_probe() name is a bit confusing, since it's not clear what
> the difference is between enable_probe() and enable_trace_kprobe()
> without looking at the code.
>
> Maybe call it __enable_trace_kprobe()?

+1, I this this is better.

With that function name change,

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

>
> Otherwise it's a definite improvement.
>
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> --
> Josh


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2018-07-27 14:52    [W:0.875 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site