lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 09/33] net/mlx5e: Fix quota counting in aRFS expire flow
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eran Ben Elisha <eranbe@mellanox.com>

    [ Upstream commit 2630bae8018823c3b88788b69fb9f16ea3b4a11e ]

    Quota should follow the amount of rules which do expire, and not the
    number of rules that were examined, fixed that.

    Fixes: 18c908e477dc ("net/mlx5e: Add accelerated RFS support")
    Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
    Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
    Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
    @@ -383,14 +383,14 @@ static void arfs_may_expire_flow(struct
    HLIST_HEAD(del_list);
    spin_lock_bh(&priv->fs.arfs.arfs_lock);
    mlx5e_for_each_arfs_rule(arfs_rule, htmp, priv->fs.arfs.arfs_tables, i, j) {
    - if (quota++ > MLX5E_ARFS_EXPIRY_QUOTA)
    - break;
    if (!work_pending(&arfs_rule->arfs_work) &&
    rps_may_expire_flow(priv->netdev,
    arfs_rule->rxq, arfs_rule->flow_id,
    arfs_rule->filter_id)) {
    hlist_del_init(&arfs_rule->hlist);
    hlist_add_head(&arfs_rule->hlist, &del_list);
    + if (quota++ > MLX5E_ARFS_EXPIRY_QUOTA)
    + break;
    }
    }
    spin_unlock_bh(&priv->fs.arfs.arfs_lock);

    \
     
     \ /
      Last update: 2018-07-27 12:14    [W:4.301 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site