Messages in this thread | | | Subject | Re: [PATCH RT v3] arm64: fpsimd: use preemp_disable in addition to local_bh_disable() | From | Mike Galbraith <> | Date | Fri, 27 Jul 2018 05:17:23 +0200 |
| |
On Thu, 2018-07-26 at 17:06 +0200, Sebastian Andrzej Siewior wrote: > > @@ -1115,6 +1139,7 @@ void kernel_neon_begin(void) > > BUG_ON(!may_use_simd()); > > + preempt_disable(); > local_bh_disable(); > > __this_cpu_write(kernel_neon_busy, true); > @@ -1131,6 +1156,7 @@ void kernel_neon_begin(void) > preempt_disable();
Nit: this preempt_disable() could be removed...
> local_bh_enable(); > + preempt_enable(); > } > EXPORT_SYMBOL(kernel_neon_begin);
...instead of adding this one.
-Mike
| |