lkml.org 
[lkml]   [2018]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: sort Kconfig menu items alphabetically
From
From: Jon Mason <jdmason@kudzu.us>
Date: Tue, 24 Jul 2018 11:43:41 -0400

> On Mon, Jul 23, 2018 at 04:01:14PM -0500, Bjorn Helgaas wrote:
>> From: Bjorn Helgaas <bhelgaas@google.com>
>>
>> 6c541b4595a2 ("net: ethernet: Sort Kconfig sourcing alphabetically")
>> sorted Kconfig sourcing based on directory names, but in a couple cases,
>> the menu item text is quite different from the directory name and is not
>> sorted correctly:
>>
>> drivers/net/ethernet/neterion/Kconfig => "Exar devices"
>
> Stupid question, does it make more sense to clarify the names in the
> Kconfig to more naturally follow what people are expecting? In the
> case of Neterion, it was standalone for several years, then aquired by
> Exar and shutdown in 11 months without ever making any Exar branded
> adatpers. Users, if they still exist, would probably think of it as
> Neterion and not Exar (as there have been no follow-on adapters and I
> don't believe any plans to ever do so).
>
> So, this might be better as a rename of the Kconfig to something like
> "Neterion (Exar) devices". Of course, there is a fair amount of Exar
> names in the Kconfig. If you agree, I can do a clean-up of this to
> match the expectations.
>
> Thoughts?

I think this is a better way to handle this.

That way, a developer can read the Kconfig file and see if the entries
are sorted properly without having to check the text of every
sub-directory entry.

\
 
 \ /
  Last update: 2018-07-26 22:41    [W:0.049 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site