lkml.org 
[lkml]   [2018]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [V9fs-developer] [PATCH] 9p: fix NULL pointer dereferences
<div dir="ltr">On 26 July 2018 at 17:48, Dominique Martinet <span dir="ltr">&lt;<a href="mailto:asmadeus@codewreck.org" target="_blank">asmadeus@codewreck.org</a>&gt;</span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Dmitry Vyukov wrote on Thu, Jul 26, 2018:<br>
&gt; &gt; Let&#39;s refuse that at much higher level, like v9fs_mount() in<br>
&gt; &gt; fs/9p/vfs_super.c<br>
&gt; &gt;<br>
&gt; &gt; I can&#39;t think of any valid reason for dev_name to be NULL, it&#39;s the<br>
&gt; &gt; target IP or virtio handle.<br>
&gt; <br>
&gt; But I think trans=fd allows NULL addr today, no?<br>
<br>
</span>Ah, right, I read the patch too fast and read unix_create as fd_create,<br>
I never realized there was a unix_create variant...<br>
<br>
fd legitimately doesn&#39;t need a name, you are correct.<br>
<br>
I&#39;m really curious if anyone ever uses the unix/fd variants for &quot;real&quot;<br>
stuff though! </blockquote><div><br></div><div>
<div>I definitely used the unix variant for mounting plan9port servers (which all listen for 9p requests via unix sockets).</div><div><br></div><div>A
long time ago I also experimented with mounting p9p servers from remote
machines and I think I might have combined socat with -o trans=fd at
one point. But I gave up on it in the end because having a process blocked in read() was preventing my laptop from going to sleep for the duration. And since I was trying to read /event type files the Tread could block for quite some time if no events were posted.</div><div><br></div><div>I believe 9pfuse had the same issue, so the problem be deeper than v9fs. But anyway I&#39;m on quite a tangent already so I&#39;ll stop distracting you all from the work at hand. It&#39;s been nice to see 9p still kicking recently! :)<br></div>

 </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">(not meaning syzbot isn&#39;t real, but I have yet to see<br>
anything take advantage of this, even if I could imagine some fun<br>
applications by piping the wmii libixp server socket.. <br></blockquote><div><br></div><div>Wait woahhhhh, there&#39;s another wmii user left? I thought I was the last one!</div><div>-sqweek<br></div><div><br></div><br></div></div></div>
\
 
 \ /
  Last update: 2018-07-26 16:49    [W:0.082 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site