Messages in this thread | | | Subject | Re: [PATCH v2] cpu/hotplug: Fix cpuhp_step name for timers | From | Mukesh Ojha <> | Date | Thu, 26 Jul 2018 17:22:58 +0530 |
| |
Hi All,
Can i get input on this ?
Thanks, Mukesh On 7/24/2018 8:17 PM, Mukesh Ojha wrote: > After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases > on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE > instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead" > for timer looks to be invalid. So, better to name it as > "timers:prepare". > > Signed-off-by: Mukesh Ojha <mojha@codeaurora.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Lai Jiangshan <jiangshanlai@gmail.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Brendan Jackman <brendan.jackman@arm.com> > Cc: Mathieu Malaterre <malat@debian.org> > --- > Changes in v2: > - Updated commit text. > > kernel/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index 0db8938..8e6606a 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void) > * otherwise a RCU stall occurs. > */ > [CPUHP_TIMERS_PREPARE] = { > - .name = "timers:dead", > + .name = "timers:prepare", > .startup.single = timers_prepare_cpu, > .teardown.single = timers_dead_cpu, > },
| |