lkml.org 
[lkml]   [2018]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] mmc: tmio: rename files and CONFIG options to have the same prefix
Hi Yamada-san,

On Thu, Jul 26, 2018 at 11:15 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2018-07-26 17:25 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> > On Thu, Jul 26, 2018 at 5:33 AM Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> >> This commit renames files as follows:
> >>
> >> tmio_mmc_core.c -> tmio_mmc.c
> >> tmio_mmc.c -> tmio_mmc_original.c
> >> renesas_sdhi_core.c -> tmio_mmc_sdhi.c
> >> renesas_sdhi.h -> tmio_mmc_sdhi.h
> >> renesas_sdhi_internal_dmac.c -> tmio_mmc_sdhi_internal_dmac.c
> >> renesas_sdhi_sys_dmac.c -> tmio_mmc_sdhi_sys_dmac.c
> >
> > I have mixed feelings about the last two renames, especially about the last
> > one: SYS-DMAC is very Renesas-specific, as it's a separate IP block in
> > Renesas SoCs.

> > 2. Are there other SoCs using an external DMAC?
>
> Yes. Some old SoCs in UniPhier SoC family rely on
> the external DMAC, like renesas_sdhi_sys_dmac.c
>
> > Is the interface to the external DMAC similar?
> > If yes, perhaps it should be renamed to tmio_mmc_sdhi_external_dmac.c?
>
> "sdhi" is already Renesas-specific name, isn't it?

Right, I'm mixing up SDHI and SDHC.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2018-07-26 11:29    [W:0.562 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site