Messages in this thread Patch in this message | | | From | Prakruthi Deepak Heragu <> | Subject | [PATCH v1] checkpatch: check for #if 0/#if 1 | Date | Wed, 25 Jul 2018 16:14:05 -0700 |
| |
The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 is present and suggest that they can be removed.
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org> Signed-off-by: Prakruthi Deepak Heragu <pheragu@codeaurora.org> --- Changes in v1: - Rephrase the warning message to fit in a single line without 80 column limit
scripts/checkpatch.pl | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3394ed8..72513c2 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5383,9 +5383,14 @@ sub process { # warn about #if 0 if ($line =~ /^.\s*\#\s*if\s+0\b/) { - CHK("REDUNDANT_CODE", - "if this code is redundant consider removing it\n" . - $herecurr); + WARN("IF_0", + "Consider removing the #if 0 and its #endif\n". $herecurr); + } + +# warn about #if 1 + if ($line =~ /^.\s*\#\s*if\s+1\b/) { + WARN("IF_1", + "Consider removing the #if 1 and its #endif\n". $herecurr); } # check for needless "if (<foo>) fn(<foo>)" uses -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |