lkml.org 
[lkml]   [2018]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_create_channel memory leak
    From
    Date
    Hi Loic,

    On 07/25/2018 04:08 PM, Loic Pallardy wrote:
    > In case of rpmsg_register_device() failure, vch previously
    > allocated must be free.
    >

    Isn't this already handled through the virtio_rpmsg_release_device()
    callback as part of the put_device() in rpmsg_register_device() failure.

    regards
    Suman

    > fixes: 6eed598a0491 ("rpmsg: Split off generic tail of create_channel()")
    >
    > Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
    > ---
    > drivers/rpmsg/virtio_rpmsg_bus.c | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
    > index 664f957..10f927e 100644
    > --- a/drivers/rpmsg/virtio_rpmsg_bus.c
    > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
    > @@ -431,8 +431,10 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
    > rpdev->dev.parent = &vrp->vdev->dev;
    > rpdev->dev.release = virtio_rpmsg_release_device;
    > ret = rpmsg_register_device(rpdev);
    > - if (ret)
    > + if (ret) {
    > + kfree(vch);
    > return NULL;
    > + }
    >
    > return rpdev;
    > }
    >

    \
     
     \ /
      Last update: 2018-07-26 00:36    [W:4.741 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site