Messages in this thread | | | Subject | Re: [PATCH 6/7] powerpc/traps: Print signal name for unhandled signals | From | Gustavo Romero <> | Date | Wed, 25 Jul 2018 12:19:00 -0300 |
| |
Hi Murilo,
LGTM.
Just a comment:
On 07/24/2018 04:27 PM, Murilo Opsfelder Araujo wrote: > This adds a human-readable name in the unhandled signal message. > > Before this patch, a page fault looked like: > > Jul 11 16:04:11 localhost kernel: pandafault[6303]: unhandled signal 11 at 00000000100007d0 nip 000000001000061c lr 00007fff93c55100 code 2 in pandafault[10000000+10000] > > After this patch, a page fault looks like: > > Jul 11 18:14:48 localhost kernel: pandafault[6352]: segfault (11) at 000000013a2a09f8 nip 000000013a2a086c lr 00007fffb63e5100 code 2 in pandafault[13a2a0000+10000]
I _really_ don't want to bikeshed here, but I vouch for keeping the "unhandled" word before the signal name, like:
[...] pandafault[6352]: unhandled segfault (11) at 000000013a2a09f8 nip [...]
because the issue reported here is really that we got a segfault _and_ there was no handler to catch it.
But feel free to wait for additional comments to decide it.
Cheers, Gustavo
| |