Messages in this thread | | | Subject | Re: [PATCH] ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002 | From | "Agrawal, Akshu" <> | Date | Wed, 25 Jul 2018 14:30:04 +0530 |
| |
On 7/24/2018 10:44 PM, Mark Brown wrote: > On Mon, Jul 23, 2018 at 10:56:44AM +0530, Agrawal, Akshu wrote: > >> This approach shows inconsistencies and in some boot cycles da7219 fails >> to get regulator. Form the logs (below) it shows time gap between the >> time we call “platform_device_register(&acp_da7219_regulator);” and when >> the regulator actually gets registered. > > This hack isn't going to help with that AFAICT, you're still registering > a platform device and relying on it appearing in time? It just > registers less often.
Yes, I agree and by "this approach" I also meant registering platform device and waiting for its probe to happen.
Instead of adding a platform device to the reg-fixed-voltage, we can register a regulator and thus not wait for the probe to occur. Pushing a v2 with this change which has consistent behavior.
Thanks, Akshu
| |